Support map and set #1565
Merged
Support map and set #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7815e2f820c4a490f4aa642beb7f5dc7eb765faf)
(cherry picked from commit 60062f8d683b696923d63f7b8d03dc7fba123f99)
|
Depend on: shekohex/allo-isolate#54 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
- Coverage 99.21% 99.21% -0.01%
==========================================
Files 343 342 -1
Lines 13338 13423 +85
==========================================
+ Hits 13233 13317 +84
- Misses 105 106 +1 ☔ View full report in Codecov by Sentry. |
5 tasks
|
Will merge after shekohex/allo-isolate#54 and upstream release is done (the failed CI is because of temporary change of allo-isolate dependency) |
# Conflicts: # frb_rust/src/misc/into_into_dart.rs
# Conflicts: # frb_example/pure_dart/lib/src/rust/frb_generated.dart # frb_example/pure_dart/lib/src/rust/frb_generated.io.dart # frb_example/pure_dart/lib/src/rust/frb_generated.web.dart # frb_example/pure_dart/rust/src/frb_generated.io.rs # frb_example/pure_dart/rust/src/frb_generated.rs # frb_example/pure_dart/rust/src/frb_generated.web.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Close #1564
Checklist
./frb_internal precommit --mode slow(orfast) is run (it internal runs code generator, does auto formatting, etc)../websitefolder) are updated.Remark for PR creator
./frb_internal --helpshows utilities for development.