(wip) added eslint

[nfcampos]

@gaearon want to review the config?

I still need to fix most of the files to conform to the config

closes #274

[gaearon]

I’m fine with using double quotes everywhere. (for JSX)

[nfcampos]

using double quotes for jsx and single quotes for everything else isn't weird?

[gaearon]

It’s weird but apparently it’s what everyone else is doing these days 😄

[nfcampos]

double quotes it is then 😄

[gaearon]

Looks good. I left a few comments.
You can try using eslint --fix . to get some of these fixed.

[nfcampos]

Yeah --fix helps at least with the semicolons, adding semicolons in hundreds of lines manually would have been terrible

[nfcampos]

@gaearon you wrote some of the files without const, import, stuff like that, any reason to keep them like that, since we're building everything with babel? I need to either change them or change the eslint rules

[gaearon]

If we use ES modules everywhere, we should add the commonjs compat plugin so that react-hot-loader/webpack and react-hot-loader/babel keep working as they are.

[nfcampos]

add the plugin to babel?

[gaearon]

Yeah, this one: https://www.npmjs.com/package/babel-plugin-add-module-exports. Not sure if it works well though. Never tried it.

[nfcampos]

hmm, not worth it then I think. basically I'm getting a bunch of error 'use strict' is unnecessary inside of modules from this rule http://eslint.org/docs/rules/strict + airbnb config adding parserOptions: {sourceType: 'module' } to the eslint config. So all of the non-es6 modules files in src/ are being interpreted as being modules and thus not needing 'use strict'. but i dont think it's possible to disable parserOptions on a single file. should i just disable the strict rule?

[gaearon]

I’m a bit confused. I meant that we can use ES modules everywhere in the code. We just need to make sure that the CommonJS compat code is generated as part of Babel compilation for entry points like /babel and /webpack. Does this make sense? Or are you saying this makes ESLint fail?

[nfcampos]

what i'm saying is that it currently works great the way it's written so instead of changing everything to es6 modules just to appease eslint it's easier to selectively disable the offending rule, no?

[gaearon]

what i'm saying is that it currently works great the way it's written so instead of changing everything to es6 modules just to appease eslint it's easier to selectively disable the offending rule, no?

Works for me 👍

[nfcampos]

Alright, I've finished fixing all the linting errors. Give it a look if you want, I think/hope I didn't break anything. Let's merge this soon to avoid merge conflicts

[gaearon]

There’s a missing space after the period in the error message. The sentences will collide.
Also a style nit: let’s put a newline right after the opening paren.

[nfcampos]

Good catch

[gaearon]

The error message needs to be fixed but the rest is up to your judgement.