(wip) added eslint

.eslintignore

@@ -0,0 +1,2 @@
+test/babel/fixtures
+lib

.eslintrc

@@ -0,0 +1,16 @@
+{
+  "extends": "airbnb",
+  "parserOptions": {
+    "ecmaFeatures": {
+      "experimentalObjectRestSpread": true
+    },
+  },
+  "rules": {
+    "no-underscore-dangle": ["error", { "allow": ["__REACT_HOT_LOADER__"] }],
+    "no-console": ["error", { allow: ["error"] }],
+    "strict": 0,
+  },
+  globals: {
+    "__REACT_HOT_LOADER__": true
+  }
+}

.travis.yml

@@ -2,3 +2,6 @@ language: node_js
 node_js:
   - "5"
   - "6"
+script:
+  - npm run lint
+  - npm test

babel.js

@@ -1 +1 @@
-module.exports = require('./lib/babel');
+module.exports = require('./lib/babel');

index.js

@@ -1 +1 @@
-module.exports = require('./lib/index');
+module.exports = require('./lib/index');

package.json

@@ -14,6 +14,7 @@
     "build": "babel src --out-dir lib",
     "test": "mocha --compilers js:babel-core/register ./test",
     "test:watch": "npm run test -- --watch",
+    "lint": "eslint .",
     "prepublish": "npm run clean && npm run build"
   },
   "dependencies": {
@@ -52,6 +53,11 @@
     "babel-preset-es2015": "^6.6.0",
     "babel-preset-react": "^6.5.0",
     "enzyme": "^2.2.0",
+    "eslint": "^2.9.0",
+    "eslint-config-airbnb": "^8.0.0",
+    "eslint-plugin-import": "^1.6.1",
+    "eslint-plugin-jsx-a11y": "^1.0.4",
+    "eslint-plugin-react": "^5.0.1",
     "expect": "^1.16.0",
     "jsdom": "^8.4.1",
     "mocha": "^2.4.5",

patch.js

@@ -1 +1 @@
-module.exports = require('./lib/patch');
+module.exports = require('./lib/patch');

src/AppContainer.dev.js

@@ -25,11 +25,11 @@ class AppContainer extends Component {
     }
   }
 
-  componentWillReceiveProps(nextProps) {
+  componentWillReceiveProps() {
     // Hot reload is happening.
     // Retry rendering!
     this.setState({
-      error: null
+      error: null,
     });
     // Force-update the whole tree, including
     // components that refuse to update.
@@ -40,9 +40,9 @@ class AppContainer extends Component {
   // In 15.0, it only catches errors on initial mount.
   // Later it will work for updates as well:
   // https://github.com/facebook/react/pull/6020
-  unstable_handleError(error) {
+  unstable_handleError(error) { // eslint-disable-line camelcase
     this.setState({
-      error: error
+      error,
     });
   }
 
@@ -54,38 +54,46 @@ class AppContainer extends Component {
 
     if (this.props.component) {
       return <this.props.component {...this.props.props} />;
-    } else {
-      return React.Children.only(this.props.children);
     }
+
+    return React.Children.only(this.props.children);
   }
 }
 
 AppContainer.propTypes = {
-  component: function (props) {
+  component(props) {
     if (props.component) {
       return new Error(
-        `Passing "component" prop to <AppContainer /> is deprecated. ` +
-        `Replace <AppContainer component={App} /> with <AppContainer><App /></AppContainer>.`
+        'Passing "component" prop to <AppContainer /> is deprecated. ' +
+        'Replace <AppContainer component={App} /> with <AppContainer><App /></AppContainer>.'
       );
     }
+
+    return undefined;
   },
-  props: function (props) {
+  props(props) {
     if (props.props) {
       return new Error(
-        `Passing "props" prop to <AppContainer /> is deprecated. ` +
-        `Replace <AppContainer component={App} props={{ myProp: myValue }} /> with <AppContainer><App myProp={myValue} /></AppContainer>.`
+        'Passing "props" prop to <AppContainer /> is deprecated. ' +
+        'Replace <AppContainer component={App} props={{ myProp: myValue }} /> ' +
+        'with <AppContainer><App myProp={myValue} /></AppContainer>.'
       );
     }
+
+    return undefined;
   },
-  children: function (props) {
+  children(props) {
     if (React.Children.count(props.children) !== 1) {
-      return new Error(`Invalid prop "children" supplied to AppContainer. Expected a single React element with your app’s root component, e.g. <App />.`);
+      return new Error('Invalid prop "children" supplied to AppContainer.' +
+        'Expected a single React element with your app’s root component, e.g. <App />.');
     }
-  }
+
+    return undefined;
+  },
 };
 
 AppContainer.defaultProps = {
-  errorReporter: Redbox
+  errorReporter: Redbox,
 };
 
 module.exports = AppContainer;

src/AppContainer.js

@@ -1,3 +1,5 @@
+/* eslint-disable global-require */
+
 'use strict';
 
 if (process.env.NODE_ENV === 'production') {

src/AppContainer.prod.js

@@ -1,3 +1,5 @@
+/* eslint-disable react/prop-types */
+
 'use strict';
 
 const React = require('react');

src/babel/index.js

@@ -14,7 +14,7 @@ const buildTagger = template(`
 })();
 `);
 
-module.exports = function(args) {
+module.exports = function plugin(args) {
   // This is a Babel plugin, but the user put it in the Webpack config.
   if (this && this.callback) {
     throw new Error(
@@ -38,27 +38,28 @@ module.exports = function(args) {
   // Try our best to avoid variables from require().
   // Ideally we only want to find components defined by the user.
   function shouldRegisterBinding(binding) {
-    let { type, node } = binding.path;
+    const { type, node } = binding.path;
     switch (type) {
-    case 'FunctionDeclaration':
-    case 'ClassDeclaration':
-    case 'VariableDeclaration':
-      return true;
-    case 'VariableDeclarator':
-      const { init } = node;
-      if (t.isCallExpression(init) && init.callee.name === 'require') {
-        return false;
+      case 'FunctionDeclaration':
+      case 'ClassDeclaration':
+      case 'VariableDeclaration':
+        return true;
+      case 'VariableDeclarator': {
+        const { init } = node;
+        if (t.isCallExpression(init) && init.callee.name === 'require') {
+          return false;
+        }
+        return true;
       }
-      return true;
-    default:
-      return false;
+      default:
+        return false;
     }
   }
 
   const REGISTRATIONS = Symbol();
   return {
     visitor: {
-      ExportDefaultDeclaration(path, { file })  {
+      ExportDefaultDeclaration(path, { file }) {
         // Default exports with names are going
         // to be in scope anyway so no need to bother.
         if (path.node.declaration.id) {
@@ -73,55 +74,57 @@ module.exports = function(args) {
           t.toExpression(path.node.declaration);
         path.insertBefore(
           t.variableDeclaration('const', [
-            t.variableDeclarator(id, expression)
+            t.variableDeclarator(id, expression),
           ])
-        )
-        path.node.declaration = id;
+        );
+        path.node.declaration = id; // eslint-disable-line no-param-reassign
 
         // It won't appear in scope.bindings
         // so we'll manually remember it exists.
         path.parent[REGISTRATIONS].push(
           buildRegistration({
             ID: id,
             NAME: t.stringLiteral('default'),
-            FILENAME: t.stringLiteral(file.opts.filename)
+            FILENAME: t.stringLiteral(file.opts.filename),
           })
         );
       },
 
       Program: {
         enter({ node, scope }, { file }) {
-          node[REGISTRATIONS] = [];
+          node[REGISTRATIONS] = []; // eslint-disable-line no-param-reassign
 
           // Everything in the top level scope, when reasonable,
           // is going to get tagged with __source.
-          for (let id in scope.bindings) {
+          /* eslint-disable guard-for-in,no-restricted-syntax */
+          for (const id in scope.bindings) {
             const binding = scope.bindings[id];
             if (shouldRegisterBinding(binding)) {
               node[REGISTRATIONS].push(buildRegistration({
                 ID: binding.identifier,
                 NAME: t.stringLiteral(id),
-                FILENAME: t.stringLiteral(file.opts.filename)
+                FILENAME: t.stringLiteral(file.opts.filename),
               }));
             }
           }
+          /* eslint-enable */
         },
 
-        exit({ node, scope }) {
-          let registrations = node[REGISTRATIONS];
-          node[REGISTRATIONS] = null;
+        exit({ node }) {
+          const registrations = node[REGISTRATIONS];
+          node[REGISTRATIONS] = null; // eslint-disable-line no-param-reassign
 
           // Inject the generated tagging code at the very end
           // so that it is as minimally intrusive as possible.
           node.body.push(buildSemi());
           node.body.push(
             buildTagger({
-              REGISTRATIONS: registrations
+              REGISTRATIONS: registrations,
             })
           );
           node.body.push(buildSemi());
-        }
-      }
-    }
+        },
+      },
+    },
   };
-}
+};

src/index.js

@@ -34,6 +34,6 @@ module.exports = function warnAboutIncorrectUsage(arg) {
       'require("react-hot-loader").AppContainer.'
     );
   }
-}
+};
 
 module.exports.AppContainer = AppContainer;

src/patch.dev.js

@@ -24,14 +24,16 @@ class ComponentMap {
   get(type) {
     if (this.wm) {
       return this.wm.get(type);
-    } else {
-      const slot = this.getSlot(type);
-      for (let i = 0; i < slot.length; i++) {
-        if (slot[i].key === type) {
-          return slot[i].value;
-        }
+    }
+
+    const slot = this.getSlot(type);
+    for (let i = 0; i < slot.length; i++) {
+      if (slot[i].key === type) {
+        return slot[i].value;
       }
     }
+
+    return undefined;
   }
 
   set(type, value) {
@@ -52,15 +54,15 @@ class ComponentMap {
   has(type) {
     if (this.wm) {
       return this.wm.has(type);
-    } else {
-      const slot = this.getSlot(type);
-      for (let i = 0; i < slot.length; i++) {
-        if (slot[i].key === type) {
-          return true;
-        }
+    }
+
+    const slot = this.getSlot(type);
+    for (let i = 0; i < slot.length; i++) {
+      if (slot[i].key === type) {
+        return true;
       }
-      return false;
     }
+    return false;
   }
 }
 
@@ -80,7 +82,7 @@ const hooks = {
     if (typeof uniqueLocalName !== 'string' || typeof fileName !== 'string') {
       return;
     }
-    const id = fileName + '#' + uniqueLocalName;
+    const id = fileName + '#' + uniqueLocalName; // eslint-disable-line prefer-template
     if (!idsByType.has(type) && hasCreatedElementsByType.has(type)) {
       if (!didWarnAboutID[id]) {
         didWarnAboutID[id] = true;
@@ -113,7 +115,7 @@ const hooks = {
     didWarnAboutID = {};
     hasCreatedElementsByType = new ComponentMap(useWeakMap);
     idsByType = new ComponentMap(useWeakMap);
-  }
+  },
 };
 
 hooks.reset(typeof WeakMap === 'function');
@@ -127,12 +129,12 @@ function resolveType(type) {
   hasCreatedElementsByType.set(type, true);
 
   // When available, give proxy class to React instead of the real class.
-  var id = idsByType.get(type);
+  const id = idsByType.get(type);
   if (!id) {
     return type;
   }
 
-  var proxy = proxiesByID[id];
+  const proxy = proxiesByID[id];
   if (!proxy) {
     return type;
   }

src/patch.js

@@ -1,3 +1,5 @@
+/* eslint-disable global-require */
+
 'use strict';
 
 if (process.env.NODE_ENV === 'production') {

src/webpack/index.js

@@ -48,20 +48,20 @@ function transform(source, map) {
   if (this.sourceMap === false) {
     return this.callback(null, [
       source,
-      appendText
+      appendText,
     ].join(separator));
   }
 
   if (!map) {
-    map = makeIdentitySourceMap(source, this.resourcePath);
+    map = makeIdentitySourceMap(source, this.resourcePath); // eslint-disable-line no-param-reassign
   }
   const node = new SourceNode(null, null, null, [
     SourceNode.fromStringWithSourceMap(source, new SourceMapConsumer(map)),
-    new SourceNode(null, null, this.resourcePath, appendText)
+    new SourceNode(null, null, this.resourcePath, appendText),
   ]).join(separator);
 
   const result = node.toStringWithSourceMap();
-  this.callback(null, result.code, result.map.toString());
-};
+  return this.callback(null, result.code, result.map.toString());
+}
 
 module.exports = transform;