Fix GalaxyReportsService crash and remove config_type #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone for a review & merge , please ? |
|
Was it necessary to drop EDIT: Actually, I'll do some testing, maybe it's ok. |
|
I'm not sure how to reproduce the test failure, it works for me locally. |
|
It is the trailing slash on the prefix |
1) Line 156 : self.config_type = self.Config.config_type is throwing: "type object 'BaseConfig' has no attribute 'config_type'" , but is ignored by gravity. Thus config file type is not assigned for services but its silent. 2) If any exception occurs in the Service class constructor those are hidden by a not subscriptable exception. Fix 1) by removing config_type form ConfigFile and Service classes, 2) by re-throwing exception in the class constructor.
Dedicated function for absolute path update, check for undefined values and use the property access.
Fix typo.
natefoo
force-pushed
the
bye_config_type
branch
from
d1b7caa
to
9f73ede
Compare
|
Thanks @jvanbraekel and sorry for the wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This fix #115.
In addition it also make the ConfigFile class more robust by catching exceptions in the constructor; they were ignored previously.
Finally, it delete the config_type in both ConfigFile and Service classes. Firstly because it wasn't copied properly in the Service class constructor (the error was silent due to the previous issue), secondly because it has no current use.
I tested the supervisor configuration locally but not the systemd one.