Fix GalaxyReportsService crash and remove config_type #116
Commits on Feb 6, 2024
-
Remove config_type from Service and ConfigFile
1) Line 156 : self.config_type = self.Config.config_type is throwing: "type object 'BaseConfig' has no attribute 'config_type'" , but is ignored by gravity. Thus config file type is not assigned for services but its silent. 2) If any exception occurs in the Service class constructor those are hidden by a not subscriptable exception. Fix 1) by removing config_type form ConfigFile and Service classes, 2) by re-throwing exception in the class constructor.
-
Fix the object not subscriptable exception
Dedicated function for absolute path update, check for undefined values and use the property access.
-
-
-
-
-
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.