Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through .values.backup.secretData #15

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Pass through .values.backup.secretData #15

merged 3 commits into from
Mar 12, 2024

Conversation

j2L4e
Copy link
Member

@j2L4e j2L4e commented Mar 12, 2024

Reverts #11.

Passing through is the easiest way to support any credentials that etcd-backup-restore supports. Noop rewrites were removed.

Edit: I think we should get rid of these rewrites altogether if possible.

Copy link
Member

@lotharbach lotharbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just not 100% sure what happens when the un-translated keys are also present in the output as well. I don't think it matters and I'm willing to just try it.

With values:

backup:
  storageProvider: ABS
  secretData:
    storage-key: foo
    storage-account: bar

it now produces this secret:

apiVersion: v1
kind: Secret
metadata:
  name: etcd-backup
  namespace: default
type: Opaque
data:
  storage-account: bar
  storage-key: foo
  storageAccount: bar
  storageKey: foo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants