Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set stringData in backup secret #17

Merged
merged 1 commit into from
May 27, 2024

Conversation

maboehm
Copy link
Contributor

@maboehm maboehm commented May 27, 2024

#15 re-introduced the option to pass through any key-value data to the backup secret. Unfortunately, this requires the data to be already base64 encoded, which is not always feasible / easy to provide.

This small change adds an additional field backup.secretStringData which is passed as stringData into the secret.

@j2L4e j2L4e self-requested a review May 27, 2024 10:06
Copy link
Member

@j2L4e j2L4e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j2L4e j2L4e merged commit d6e54f2 into gardener-community:main May 27, 2024
@maboehm maboehm deleted the backup-stringdata branch May 27, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants