Machine object deletion will proceed if backing VM not found #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
|
@AxiomSamarth I would like to merge this PR before PR #58 , as both have clashing changes. So rebase will be req. |
AxiomSamarth
reviewed
Jan 3, 2022
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
himanshu-kun
added
the
reviewed/ok-to-test
himanshu-kun
changed the title
himanshu-kun
force-pushed
the
no-backing-vm-deletion
branch
from
6736fce to
496a9bb
Compare
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
The I verified that the integration tests and unit tests pass locally and so have merged the PR as this PR needed some discussion before merging |
rishabh-11
added a commit
to rishabh-11/machine-controller-manager-provider-aws
that referenced
this pull request
Sep 6, 2023
himanshu-kun
pushed a commit
that referenced
this pull request
Sep 21, 2023
* map aws error codes to mcm error codes * temporary vendor changes * add error code to replace PR #59 * map ResourceExhausted error code for CreateMachine call * remove unused variables from mockclient.go * revert mcm vendor changes * resolved make check errors * address review comments * address review comments part-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Till now for cases where a machine obj has ProviderID but the instance on provider is not found , deletion had been be retried.
With This PR if the AWS api returns
InvalidInstanceIDNotFounderror (which was earlier taken as an Internal error and not handled) , the instance deletion is assumed to be success.Eventual consistency can't occur in this case as another PR handles that case for CreateMachine and so it can't reach DeleteMachine.
Also in worst case if instance still exists and we assumed its deletion with this new logic, orphan VM collection will deal with it.
Refer live issue 1201
Which issue(s) this PR fixes:
Fixes #56
Special notes for your reviewer:
I have changed the mockClient functions to return
InvalidInstanceIDNotFounderror in case instance is not found (which was not done earlier) . This mimics the actual behavior of AWS API.The existing testcases are changed accordingly
Also wait for 5min is NOT introduced, as that would deviate the code from other providers a lot.
Release note: