Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ginkgo v1 for tests #62

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Use ginkgo v1 for tests #62

merged 1 commit into from
Jan 10, 2022

Conversation

himanshu-kun
Copy link
Contributor

What this PR does / why we need it:
Recently there has been a major version jump in ginkgo, due to which tests are failing.
This PR will enable use of latest v1.16.5 of ginkgo for tests.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
go install is used as it doesn't affect go.mod and go get doesn't support getting a particular version without affecting go.mod.
Release note:

Ginkgo version 1.16.5 is used for tests until changes compatible with v2.0.0 are made.

@himanshu-kun himanshu-kun requested review from a team as code owners January 3, 2022 12:13
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 3, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 3, 2022
@himanshu-kun
Copy link
Contributor Author

@AxiomSamarth we might have to raise similar PRs on all providers. I wonder if there is anything like this done in other Gardener repos?

@himanshu-kun himanshu-kun mentioned this pull request Jan 6, 2022
Merged
@himanshu-kun
Copy link
Contributor Author

Merging after discussion with colleagues

@himanshu-kun himanshu-kun merged commit 76f2a77 into gardener:master Jan 10, 2022
@himanshu-kun himanshu-kun deleted the use-ginkgo-v1 branch January 10, 2022 10:28
@AxiomSamarth AxiomSamarth mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxiomSamarth AxiomSamarth AxiomSamarth approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himanshu-kun @AxiomSamarth @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot