fix: rare deadlock in GetOperationEvents #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thinkscape
reviewed
Jun 4, 2024
| select { | ||
| case errChan <- errors.New("event buffer overflow, closing stream for client retry and catchup"): | ||
| default: | ||
| } |
There was a problem hiding this comment.
This is a semi-decent indication of disconnection/unresponsive client - does this case here result in proper socket disconnection?
There was a problem hiding this comment.
Yes -- the logic is a bit convoluted, I'd like to followup and refactor it to use some better golang patterns, but essentially the function is expected to return with the first error sent to errChan (which also disconnects the client), all following values should be dropped on the floor since there's no longer a connected client to send the errors to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.