-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-offline): reload when missing resources and SW was updated + add "onServiceWorkerUpdateReady" API #10432
Merged
pieh
merged 18 commits into
gatsbyjs:master
from
vtenfys:dont-auto-reload-after-sw-update
Jan 28, 2019
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1f26ef1
refactor(gatsby-plugin-offline): only reload if necessary; introduce …
80254e9
Merge branch 'master' into dont-auto-reload-after-sw-update
vtenfys 4351be6
Merge branch 'master' into dont-auto-reload-after-sw-update
30ddecd
Remove unneeded code; handle resource fail then SW update
1f1ec01
Merge branch 'master' into dont-auto-reload-after-sw-update
2506721
Merge branch 'master' into dont-auto-reload-after-sw-update
69a4696
Restore precautionary code
6d3fbb1
refactor: move code outside of if-block to decrease indentation + sho…
dc35c9e
refactor: use cpx to copy and watch sw-append-js
a558daf
fix: window.reload() -> window.location.reload()
pieh 91bd2d8
Ignore compiling sw-append.js with Babel
19a2758
Merge remote branch into local
3b945ac
Merge branch 'master'
8ca31d4
Restore previous behaviour
97db1d0
Prevent whitelisting/caching old pages/resources
f6a1be3
Merge branch 'master' into dont-auto-reload-after-sw-update
452878b
Merge remote-tracking branch 'origin/master' into dont-auto-reload-af…
pieh 3665102
update peer dep to version that will be released
pieh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's safe to remove that yet. This handles stuff before runtime actually run, so we can't really rely that any changes we make in runtime are actually in effect (not to mention that people can use "missmatched" versions of gatsby and offline plugin in this could "brick" their sites still in those still not figured out scenarios)