chore(gatsby): fix domready package to be compatible with ie10

[mikaelkristiansson]

Description

When a gatsby site is loaded in internet explorer 10 it will not render.
Since gatsby use package domready (not maintained since 4 years back) I decided to fork it and fix the problem.

this is how gatsby call the function:

domReady(() => {
      renderer(
        <NewRoot />,
        typeof window !== `undefined`
          ? document.getElementById(`___gatsby`)
          : void 0,
        () => {
          postInitialRenderWork()
          apiRunner(`onInitialClientRender`)
        }
      )
    })

but since domready isn't working correct in ie10 the renderer function won't be called.

The problem causing this in domready package was it calls

document.documentElement.doScroll

in ie10 this returns as a function, so I had to change it to call the function to get the value expected:

ie10 ? document.documentElement.doScroll() : document.documentElement.doScroll

link to package and git repo:
https://www.npmjs.com/package/domready-loaded
https://github.com/mikaelkristiansson/domready

Related Issues

Fixes this issue: #11604

[wardpeet]

why wouldn't you publish it on your own name @mikaelkristiansson/domready? Also you should create a PR for this on his repo so we can switch back to domready later on.

Another approach is just doing it ourselves XD For ie9+ we don't need any doScroll hacks.

function domReady(cb => {
  if (!document) {return}
  if (document.readyState === 'complete') {
    return cb()
  }

  document.addEventListener('DOMContentLoaded', function listener() {
    document.removeEventListener('DOMContentLoaded', listener);
    cb()
  })
});

[mikaelkristiansson]

I've created a PR to the original repo:
ded/domready#59
and also updated package to use @mikaelkristiansson/domready

[wardpeet]

thanks! Let me also explain why @mikaelkristiansson/domready is valuable for us instead of domready-loaded. This mostly indicated that this is a temp package derived from domready. With domready-loaded we have to open your github to see that it's a fork, ...

[wardpeet]

Looks good!

[gatsbot]

Holy buckets, @mikaelkristiansson — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!