Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix commas and tweak small issues in tutorial #13031

Merged
merged 12 commits into from
Apr 4, 2019

Conversation

dhurlburtusa
Copy link
Contributor

No description provided.

@dhurlburtusa dhurlburtusa requested a review from a team April 2, 2019 13:45
@DSchau DSchau changed the title Fix Comma Usage chore(docs): fix commas and tweak small issues in tutorial Apr 2, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good--can we incorporate the changes in #13032 and #13017 into this PR?

It's nice to co-locate similar groups of changes into one PR, if at all possible, and since these are linked it'd be nice to get them all in at once.

@DSchau DSchau added the status: awaiting author response Additional information has been requested from the author label Apr 2, 2019
Use em dash in place of two hyphens.
Format paragraph to be on one line (apparently the convention).
* Fix Comma Usage and Do Some Misc Changes

Do code formatting to match rest of file.
Use em dash instead of two hyphens.
Etc.

* Update HTML Entity
@DSchau
Copy link
Contributor

DSchau commented Apr 2, 2019

Thanks for unifying these! Let me know when it's ready for a review--and I'll take another look!

@dhurlburtusa
Copy link
Contributor Author

@DSchau Sure, no problem. I still have a few more of the tutorial parts to go through. I'll merge everything into this PR and then let you know.

Thanks for approving these changes.

@dhurlburtusa
Copy link
Contributor Author

@DSchau A question for you. Many times I have two reasonable choices for some of the changes involving commas: 1) simply remove the comma so that a list of two phrases are connected or 2) leave in the comma and add a subject to the second phrase thus turning it into an independent clause.

Do you have a preference?

@marcysutton
Copy link
Contributor

@dhurlburtusa it definitely depends on the context and at the same time is quite subjective. I would say use your best judgement and only change something if absolutely necessary!

* docs(gatsby-source-shopify): Add note about API permissions (#13037)

Note which permissions you should enable on the Shopify Storefront API. Without these permissions you'll get a fairly cryptic error message.

* chore(docs): match the Wording Style of Other Tutorial Parts (#13034)

* chore(docs): fix typo in convincing others doc (#13033)

<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

Fixes a misspelled word.

* fix(docs): expand guidelist on partnering with gatsby page (#13029)

Following up on #12970. Current https://www.gatsbyjs.org/docs/partnering-with-gatsby/:

![image](https://user-images.githubusercontent.com/21834/55404445-2f445080-5558-11e9-84d8-f75db8dd7297.png)

* fix(starters): update gatsby monorepo (#12925)

This PR contains the following updates:

| Package | Type | Update | Change | References |
|---|---|---|---|---|
| gatsby | dependencies | patch | [`^2.3.3` -> `^2.3.5`](https://diff.intrinsic.com/gatsby/2.3.3/2.3.5) | [source](https://togithub.com/gatsbyjs/gatsby) |
| gatsby-image | dependencies | patch | [`^2.0.35` -> `^2.0.37`](https://diff.intrinsic.com/gatsby-image/2.0.35/2.0.37) | [source](https://togithub.com/gatsbyjs/gatsby) |
| gatsby-plugin-manifest | dependencies | patch | [`^2.0.25` -> `^2.0.26`](https://diff.intrinsic.com/gatsby-plugin-manifest/2.0.25/2.0.26) | [source](https://togithub.com/gatsbyjs/gatsby) |

---

### Release Notes

<details>
<summary>gatsbyjs/gatsby</summary>

### [`v2.3.5`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5)

[Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5)

### [`v2.3.4`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4)

[Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4)

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`".

:ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/config-help/issues) if that's undesired.

---

 - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#gatsbyjs/gatsby).

* feat(blog): add gatsby is great blog post (#12777)

* chore: add blog post

* chore: keep iterating

* chore: more tweaks

* feat: nearly finish up

* chore: run tinypng

* chore: fix some typos

* chore: fix snippet

* chore: add a gif, it gets the people going

* chore: more

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* chore: change date

* chore: tighten up last section

* chore: change data

* chore: update per feedback

* chore(docs): replace absolute links with relative links (#12949)


<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

Suggest a more complete structure to the example gatsby-config.js file

## Related Issues

Along with #12103 this PR fixes #11957

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes #1234, Addresses #1234, Related to #1234, etc.
-->

* chore(showcase): Add Assortment to site showcase (#13002)

## Description

Adding [assortment.io](https://assortment.io) to site showcase. Assortment is my Web Development blog that I've recently updated to Gatsby, Netlify, Netlify CMS and Emotion. It'd be cool to see it on the showcase 😃

* Fix Comma Usage; Misc Updates
@dhurlburtusa dhurlburtusa requested a review from a team as a code owner April 3, 2019 17:06
@dhurlburtusa dhurlburtusa requested a review from a team April 3, 2019 17:06
* docs(gatsby-source-shopify): Add note about API permissions (#13037)

Note which permissions you should enable on the Shopify Storefront API. Without these permissions you'll get a fairly cryptic error message.

* chore(docs): match the Wording Style of Other Tutorial Parts (#13034)

* chore(docs): fix typo in convincing others doc (#13033)

<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

Fixes a misspelled word.

* fix(docs): expand guidelist on partnering with gatsby page (#13029)

Following up on #12970. Current https://www.gatsbyjs.org/docs/partnering-with-gatsby/:

![image](https://user-images.githubusercontent.com/21834/55404445-2f445080-5558-11e9-84d8-f75db8dd7297.png)

* fix(starters): update gatsby monorepo (#12925)

This PR contains the following updates:

| Package | Type | Update | Change | References |
|---|---|---|---|---|
| gatsby | dependencies | patch | [`^2.3.3` -> `^2.3.5`](https://diff.intrinsic.com/gatsby/2.3.3/2.3.5) | [source](https://togithub.com/gatsbyjs/gatsby) |
| gatsby-image | dependencies | patch | [`^2.0.35` -> `^2.0.37`](https://diff.intrinsic.com/gatsby-image/2.0.35/2.0.37) | [source](https://togithub.com/gatsbyjs/gatsby) |
| gatsby-plugin-manifest | dependencies | patch | [`^2.0.25` -> `^2.0.26`](https://diff.intrinsic.com/gatsby-plugin-manifest/2.0.25/2.0.26) | [source](https://togithub.com/gatsbyjs/gatsby) |

---

### Release Notes

<details>
<summary>gatsbyjs/gatsby</summary>

### [`v2.3.5`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5)

[Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5)

### [`v2.3.4`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4)

[Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4)

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`".

:ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/config-help/issues) if that's undesired.

---

 - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#gatsbyjs/gatsby).

* feat(blog): add gatsby is great blog post (#12777)

* chore: add blog post

* chore: keep iterating

* chore: more tweaks

* feat: nearly finish up

* chore: run tinypng

* chore: fix some typos

* chore: fix snippet

* chore: add a gif, it gets the people going

* chore: more

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* chore: change date

* chore: tighten up last section

* chore: change data

* chore: update per feedback

* chore(docs): replace absolute links with relative links (#12949)


<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

Suggest a more complete structure to the example gatsby-config.js file

## Related Issues

Along with #12103 this PR fixes #11957

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes #1234, Addresses #1234, Related to #1234, etc.
-->

* chore(showcase): Add Assortment to site showcase (#13002)

## Description

Adding [assortment.io](https://assortment.io) to site showcase. Assortment is my Web Development blog that I've recently updated to Gatsby, Netlify, Netlify CMS and Emotion. It'd be cool to see it on the showcase 😃

* feat(gatsby-dev-cli): add verdaccio support (#11525)

* feat(gatsby-dev-cli): add verdaccio support [wip]

* yuck - don't look

* just to verify verdaccio

* fix gitignore and add htpasswd with dummy gatsby-dev user

* some logging to understand why it tries to handle all the packages

* just temporarily so it hopefully at least works

* moar data

* don't copy all the packages right now

* don't rely on package name starting with "gatsby" heuristic

* tmp commit

* tmp

* fs change

* tmp

* a

* updates

* remove random files that shouldn't be here

* tmp

* revert dep changes

* ignore changes to package.json created during publishing

* testing of dep change in gatsby-cli is picked up by gatsby-dev-cli

* let's see if gatsby-dev will handle case of no node_modules

* sanity check

* adjust console message

* add missing devDeps

* more missing devDeps

* grab package.json from unpkg if package is not yet installed locally

* correctly ignore package.json changes during publishing

* cleaning things up

* htpasswd loc

* restore gatsby package.json

* adjust ignore files

* gatsby-dev-cli: ignore tests

* remove extra ln

* less console output

* turns out you don't need htpasswd after all

* use exact when installing local packages  - timestamp is used in version

* why it failed?

* use yarn for publishing - see verdaccio/verdaccio#997

* v0.1.1

* add temporary .npmrc file to allow anonymous publishes

* add some jsdocs

* update yarn.lock

* oops

* debug why still can't publish anon

* adjust npmrc content

* doh

* Revert "debug why still can't publish anon"

This reverts commit fc1045a.

* handle package installation of deps didn't change

* skip version changes for packages in gatsby mono-repo, queue copying instead of doing it immediately

* fix tests

* packages stored in verdaccio storage seems to be picked up by jest and causing trouble, so let's ignore verdaccio storage directory

* bye "wat", you will be missed

* bail early to avoid conditional bracket hell

* more bailing early

* more concise

* new line

* use exaca to simplify running yarn

* clean up www/.gitignore

* handle not existing packages

* remove unused (was needed for basic auth)

* cleanup temp file changes when process exit in middle of publishing

* ops

* Apply suggestions from code review

Co-Authored-By: pieh <misiek.piechowiak@gmail.com>

* cleanup unpkg response handler

* move stuff around

* remove tmp comment

* document traversePackageDocs fn

* restrcuture files

* add basic tests for traversingPackageDeps

* add basic tests for generating packages to publish (based on dep graph)

* fix tests on windows

* handle circular dependencies when constructing list of packages to publish

* remove cat ;(

* restore original e2e-test script

* update gitignore

* chore(release): Publish

 - babel-plugin-remove-graphql-queries@2.6.3
 - babel-preset-gatsby@0.1.11
 - gatsby-dev-cli@2.4.13
 - gatsby-plugin-typescript@2.0.12
 - gatsby-source-shopify@2.0.23
 - gatsby@2.3.6

* chore(release): Publish

 - gatsby-dev-cli@2.4.14

* docs(gatsby-dev-cli): Edit README (#13049)

* Build out Gatsby media information in docs (#12906)

* add video info, delete unnecessary stubs

Related to #12903

* fix internal link for html5 video section

* update videoTitle example

Co-Authored-By: marcysutton <holla@marcysutton.com>

* Apply suggestions from code review

thanks for the feedback!

Co-Authored-By: marcysutton <holla@marcysutton.com>

* incorporate feedback, make into real docs!!

* delete unused stubs

* Update docs/docs/working-with-video.md

Co-Authored-By: marcysutton <holla@marcysutton.com>

* Update docs/docs/working-with-video.md

Co-Authored-By: marcysutton <holla@marcysutton.com>

* chore(gatsby): fix domready package to be compatible with ie10 (#13027)

* changed domready package to domready-loaded which is compatible with ie10

* updated domready to @mikaelkristiansson/domready

* updated packages/gatsby to use @mikaelkristiansson/domready

* chore(release): Publish

 - gatsby@2.3.7

* feat(gatsby-transformer-react-docgen): use local babel config for react-docgen (#12001)

* feat: use local babel config for react-docgen

BREAKING CHANGE: now uses the local babel config with a fallback

* Update README.md

* chore(release): Publish

 - gatsby-transformer-react-docgen@4.0.0

* chore(docs): add “Why I used GatsbyJS (#12954)

Why I used GatsbyJS

<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

<!-- Write a brief description of the changes introduced by this PR -->

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes #1234, Addresses #1234, Related to #1234, etc.
-->

* feat(www): don't check for overview frontmatter (#13060)

Fixes `[[guidelist]]` not being replaced in few pages (i.e. in https://www.gatsbyjs.org/docs/winning-over-stakeholders/ )

The code is handling cases when there are no children (tried building locally and it worked just fine).

Follow up to this would be to clear `.md` files that use `overview` and adjust page query. But this is just quick fix.

* chore(docs): add starter library to docs sidebar under starters (#12963)

 40% of people visiting the starters page go here next, so we should probably add this:

![image](https://user-images.githubusercontent.com/4388699/55285012-58d26180-5337-11e9-9259-68e81b4894ad.png)

* chore(showcase): Add gmartinez.dev to showcase (#13067)

<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

Adding gmartinez.dev to showcase list in site.yml

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes #1234, Addresses #1234, Related to #1234, etc.
-->


Co-authored-by: Lennart <lekoarts@gmail.com>

* fix(gatsby): don't try to statically analyze gatsby-node, require it and examine exports instead (#13053)

* fix: don't try to statically analyze gatsby-node, require it and examine exports instead

* differentiate test names

* Update packages/gatsby/src/bootstrap/resolve-module-exports.js

Co-Authored-By: pieh <misiek.piechowiak@gmail.com>

* chore(release): Publish

 - gatsby@2.3.8

* Use Loki's elemMatch operator (#13025)

* feat(gatsby): add util.promisify polyfill for older node version (#13024)

* refactor(gatsby): gatsby develop: cleanup port detection (#13006)

* chore(release): Publish

 - gatsby@2.3.9

* fix(gatsby): ignore __esModule export in gatsby-node exports (#13081)

I introduced bug/regression in #13053 by not removing `__esModule` export name from resolved export names - it break some plugins

Fixes: #13079

* chore(release): Publish

 - gatsby@2.3.10

* fix(www): Hubspot form UI (#13080)

* fix(www): Work around HubSpot’s CSS being loaded

…by pulling in react-hubspot-form locally, and modifying it slightly. See comment in `www/src/components/react-hubspot-form` for more info.

* Fix `formInput` styles

… now matching the reference homepage newsletter form — no more Futura PT for input text.

* Return nothing because linter

* Make into Two Words
@dhurlburtusa dhurlburtusa requested review from a team as code owners April 3, 2019 17:20
Hopefully fix a code formatting issue when in a highlighted section.
@DSchau
Copy link
Contributor

DSchau commented Apr 3, 2019

@dhurlburtusa let me know if this is ready for a review. Appreciate the work you're doing here!

@dhurlburtusa
Copy link
Contributor Author

Hi @DSchau,

I made it all the way through the tutorial and one blog article (written by you), which was very good by the way. Thanks.

I hope that I did a good job with the punctuation. I am by no means a grammar expert. I had to lookup several rules that I either never learned or had forgotten.

Thanks for accepting my contributions. I am enjoying learning about Gatsby. I am using it to build a business website.

What should I do about the prettier failure? Is there an easy way to find out what prettier is complaining about without having to clone the repo, setting it up, and then running the lint script?

Once I get the lint error resolved, then this PR will be ready to merge.

@pieh
Copy link
Contributor

pieh commented Apr 4, 2019

What should I do about the prettier failure? Is there an easy way to find out what prettier is complaining about without having to clone the repo, setting it up, and then running the lint script?

Once I get the lint error resolved, then this PR will be ready to merge.

Hey @dhurlburtusa, we will handle running formatting.

This is something we work on, to make it easier for contributors - specially for documentation changes when you don't really clone repository.

But in the meantime, you can leave it to us to handle prettier.

@dhurlburtusa
Copy link
Contributor Author

Thanks @pieh.

I see that the code formatter basically undid the change I made in the code examples that were between the highlight-start and highlight-end "tags". There appears to be a bug with the way highlighted code is rendered.

In the following screen shot from https://www.gatsbyjs.org/tutorial/part-seven/, notice how the closing brace for the css prop of the Link has had a newline added with no indentation.

tutorial_part_seven-screen_shot

Do you or anyone know how to fix this? Is this is known issue when highlighting chunks of code?

@pieh
Copy link
Contributor

pieh commented Apr 4, 2019

Ugh, sorry about that. Let me take a look

@pieh
Copy link
Contributor

pieh commented Apr 4, 2019

It definitely is line highlighting bug. I do think we need to keep it as it is right now and fix highlighting, but this should not block other changes in this pull request

@dhurlburtusa
Copy link
Contributor Author

dhurlburtusa commented Apr 4, 2019

@pieh Agreed. Thanks for your help.

@dhurlburtusa
Copy link
Contributor Author

@DSchau Ready to merge. Thanks again.

@DSchau
Copy link
Contributor

DSchau commented Apr 4, 2019

Just wanted to mention how much we appreciate these types of PRs and all the work you've done.

Thank you! 💜

@DSchau DSchau merged commit f34bd7b into master Apr 4, 2019
@DSchau DSchau deleted the dhurlburtusa-patch-3 branch April 4, 2019 19:29
@dhurlburtusa dhurlburtusa removed the status: awaiting author response Additional information has been requested from the author label Apr 4, 2019
@dhurlburtusa
Copy link
Contributor Author

Thanks @DSchau!

Would you mind elaborating a little on "we appreciate these types of PRs"?

Or do you say that to all the anal-retentive, grammar nazis? 🍩 😊

@lannonbr
Copy link
Contributor

lannonbr commented Apr 4, 2019

@dhurlburtusa I think it's more so that the tiniest of tweaks can really help out in the long run. For instance, if someone is non-native English speaker, correcting the grammar can help out with the understanding of the documentation

@DSchau
Copy link
Contributor

DSchau commented Apr 4, 2019

@dhurlburtusa we really do love these types of PRs! Grammatical issues and improvements are very much just as important as other types of contributions--even if you think they're nit-picky (I don't think this!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants