-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes broken link from Gatsbygram #15139
Conversation
Reverted the last commit to open a new PR which fixed another issue. I was working on the same branch, so forgot to switch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Holy buckets, @kindavishal — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Thank you! |
Thank you @kindavishal! Can I ask you to update these links in a new PR? They should be relative instead of absolute URLs. See my comments on #15142 for an example. The reason for relative urls is that when using absolute urls, clicking the link will trigger a full page refresh. Using relative urls means that Gatsby's Link component can prefetch the page content and update the window without having to refresh the page. |
Got it! Will do that :D |
Description
Fixes a broken link to
packages-gatsby
and closes the third task inside #14693Related Issues
Closes third task in #14693