Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken link from Gatsbygram #15139

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Conversation

kindavishal
Copy link
Contributor

Description

Fixes a broken link to packages-gatsby and closes the third task inside #14693

Related Issues

Closes third task in #14693

@kindavishal kindavishal requested a review from a team June 26, 2019 04:40
@kindavishal
Copy link
Contributor Author

Reverted the last commit to open a new PR which fixed another issue. I was working on the same branch, so forgot to switch!
The new PR is here #15142

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit 39b97d4 into gatsbyjs:master Jun 26, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 26, 2019

Holy buckets, @kindavishal — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@kindavishal kindavishal deleted the fix/packages-gatsby branch June 26, 2019 09:33
@kindavishal
Copy link
Contributor Author

Thank you!

@m-allanson
Copy link
Contributor

Thank you @kindavishal! Can I ask you to update these links in a new PR? They should be relative instead of absolute URLs. See my comments on #15142 for an example.

The reason for relative urls is that when using absolute urls, clicking the link will trigger a full page refresh. Using relative urls means that Gatsby's Link component can prefetch the page content and update the window without having to refresh the page.

@kindavishal
Copy link
Contributor Author

Thank you @kindavishal! Can I ask you to update these links in a new PR? They should be relative instead of absolute URLs. See my comments on #15142 for an example.

The reason for relative urls is that when using absolute urls, clicking the link will trigger a full page refresh. Using relative urls means that Gatsby's Link component can prefetch the page content and update the window without having to refresh the page.

Got it! Will do that :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants