Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fix/developer blog #15142

Merged
merged 7 commits into from
Jun 26, 2019
Merged

Conversation

kindavishal
Copy link
Contributor

Description

This fixes the broken link to developer blog from gatsby-vendor-partnership page. Previously it was trying to point to a directory which didn't exist, now it points to the blog

Related Issues

Fixes 6th task in issue #14693

@kindavishal kindavishal requested a review from a team June 26, 2019 08:42
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kindavishal - one small comment on these is that they should be relative links.

docs/docs/gatsby-vendor-partnership.md Outdated Show resolved Hide resolved
docs/blog/gatsbygram-case-study/index.md Outdated Show resolved Hide resolved
kindavishal and others added 2 commits June 26, 2019 09:51
Co-Authored-By: Mike Allanson <michael.allanson@gmail.com>
Co-Authored-By: Mike Allanson <michael.allanson@gmail.com>
@kindavishal
Copy link
Contributor Author

Thanks @kindavishal - one small comment on these is that they should be relative links.

Thanks @m-allanson for informing me this, I was a bit confused between the type of links, your suggestions cleared my doubt, will keep them in mind from next time! ✨

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you @kindavishal 👍

@m-allanson m-allanson added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 26, 2019
@m-allanson m-allanson changed the title Fix/developer blog fix(docs): Fix/developer blog Jun 26, 2019
@gatsbybot gatsbybot merged commit 93a28f3 into gatsbyjs:master Jun 26, 2019
@kindavishal kindavishal deleted the fix/developer-blog branch June 26, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants