feat(gatsby): add all rules from eslint-plugin-jsx-a11y #19946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
approved these changes
Dec 4, 2019
sidharthachatterjee
added
the
bot: merge on green
|
Cool! There might be a small update needed on this page...? https://www.gatsbyjs.org/docs/making-your-site-accessible/ |
|
Will there be a follow-up PR to update the docs page about the default eslint config? There is now some docs debt as the PR was merged before an update could be made. |
|
Yes I'll do that today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds all rules from eslint-plugin-jsx-a11y to our eslint config so they warn during development by default. This way, these warnings are more prominent during the dev process than those displayed in the browser console.
Related Issues
#19945