-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): update information about eslint-plugin-jsx-a11y functionality #19947
Conversation
update making-your-site-accessible to include information about default settings for `eslint-plugin-jsx-a11y`
@marcysutton is it ok to just remove the stuff about customization? It looks like if they implement rule customizations in their own .eslintrc file it will only show warnings and errors in IDE plugins and bypass the console entirely, which gets away from what we're trying to achieve by including all of the rules by default. |
@madalynrose we can do whatever we want with this, but I'll pose this question: how would a user disable a rule that doesn't apply to their situation, i.e. causing false positives that end up being ignored? Can we update the config documentation to work better with the new changes, so they can customize what goes into the console? I know from my own experience that some of the warnings aren't always relevant. |
re: customizing eslint having a local |
Update with note about how local `.eslintrc` files bypass Gatsby's `eslint-loader`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This write up is overall super helpful! Added one request for clarification.
Co-Authored-By: LB <barth.laurie@gmail.com>
Co-Authored-By: LB <barth.laurie@gmail.com>
This looks great! Awesome job Madalyn! Once this last change gets added this should be good to merge!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, the only thing I noticed was needing to move a comma!
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
Wahoo! Psyched to get this in. |
Description
update docs/making-your-site-accessible to include information about default settings for
eslint-plugin-jsx-a11y
and update docs/eslint to clarify how local.eslintrc
files are treated in GatsbyRelated PRs
#19946