Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(showcase): Add webman.pro #20332

Merged

Conversation

wwwebman
Copy link
Contributor

Description

Site showcase submission.

Documentation

Related Issues

@wwwebman wwwebman requested a review from a team as a code owner December 29, 2019 20:49
docs/sites.yml Outdated
main_url: https://webman.pro/
url: https://webman.pro/
description: >
{titleofthesite} is an awesome portfolio and technical blog where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@wwwebman wwwebman Dec 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue caused by unclear documentation. I think this line confuses people:

description: >
    {titleofthesite} is a shiny new website built with Gatsby v2 that makes important contributions towards a faster web for everyone.

We definitely have to fix the documentation somehow. Because for me {titleofthesite} looks like a variable that replaces on build. But it doesn't.

Copy link
Contributor Author

@wwwebman wwwebman Dec 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRuf How do you think should I create the issue in that case to fix the doc ^^?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow it makes sense to remove all curly braces in the example to avoid the confusion that this are variables... or make a additional note to replace the values in curly braces...

Copy link
Contributor

@muescha muescha Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw: @DanielRuf i fixed your example in #20365

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning that @wwwebman I'll take a look at updating that documentation!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

DanielRuf
DanielRuf previously approved these changes Dec 30, 2019
@lannonbr lannonbr changed the title Add webman.pro site to showcase chore(showcase): Add webman.pro Dec 30, 2019
@laurieontech
Copy link
Contributor

Thanks for the PR!

@laurieontech laurieontech merged commit 01cd414 into gatsbyjs:master Jan 3, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 3, 2020

Holy buckets, @wwwebman — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants