-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(showcase): Add webman.pro #20332
chore(showcase): Add webman.pro #20332
Conversation
docs/sites.yml
Outdated
main_url: https://webman.pro/ | ||
url: https://webman.pro/ | ||
description: > | ||
{titleofthesite} is an awesome portfolio and technical blog where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work, see https://www.gatsbyjs.org/showcase/mattferderer.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue caused by unclear documentation. I think this line confuses people:
description: >
{titleofthesite} is a shiny new website built with Gatsby v2 that makes important contributions towards a faster web for everyone.
We definitely have to fix the documentation somehow. Because for me {titleofthesite}
looks like a variable that replaces on build. But it doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielRuf How do you think should I create the issue in that case to fix the doc ^^?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somehow it makes sense to remove all curly braces in the example to avoid the confusion that this are variables... or make a additional note to replace the values in curly braces...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw: @DanielRuf i fixed your example in #20365
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning that @wwwebman I'll take a look at updating that documentation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment.
Thanks for the PR! |
Holy buckets, @wwwebman — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Site showcase submission.
Documentation
Related Issues