Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(showcase): Add webman.pro #20332

Merged
merged 4 commits into from
Jan 3, 2020
Merged

chore(showcase): Add webman.pro #20332

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6897ad3
Add webman.pro site to showcase
wwwebman Dec 29, 2019
aa490a6
Replace {titleofthesite} for webman.pro showcase
wwwebman Dec 30, 2019
4e7b4f3
Merge branch 'master' into add-webman.pro-site-to-showcase
wwwebman Jan 1, 2020
a139869
Merge branch 'master' into add-webman.pro-site-to-showcase
laurieontech Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/sites.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9069,3 +9069,17 @@
- Marketing
- Design
built_by: João Matos (Global Creative Studio - Education First)
- title: webman.pro
main_url: https://webman.pro/
url: https://webman.pro/
description: >
{titleofthesite} is an awesome portfolio and technical blog where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, see https://www.gatsbyjs.org/showcase/mattferderer.com

Copy link
Contributor Author

@wwwebman wwwebman Dec 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue caused by unclear documentation. I think this line confuses people:

description: >
    {titleofthesite} is a shiny new website built with Gatsby v2 that makes important contributions towards a faster web for everyone.

We definitely have to fix the documentation somehow. Because for me {titleofthesite} looks like a variable that replaces on build. But it doesn't.

Copy link
Contributor Author

@wwwebman wwwebman Dec 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRuf How do you think should I create the issue in that case to fix the doc ^^?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow it makes sense to remove all curly braces in the example to avoid the confusion that this are variables... or make a additional note to replace the values in curly braces...

Copy link
Contributor

@muescha muescha Dec 31, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw: @DanielRuf i fixed your example in #20365

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning that @wwwebman I'll take a look at updating that documentation!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurieontech => #20373

professional Front End engineer Dmytro Chumak shares his thoughts
and experience to inspire other developers.
featured: false
categories:
- Blog
- Web Development
- JavaScript
built_by: Dmytro Chumak
built_by_url: https://github.com/wwwebman