Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: more cleanup after Node 8 drop #20343

Merged
merged 7 commits into from
Mar 20, 2020
Merged

chore: more cleanup after Node 8 drop #20343

merged 7 commits into from
Mar 20, 2020

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Dec 30, 2019 •
edited
Loading

Description

Node.js v8 is scheduled to stop maintenance on December 2019.
Please see https://nodejs.org/en/about/releases/

This is still draft. This will be opened when Node.js v8 will be End-of-Life.

Documentation

Related Issues

@shisama shisama marked this pull request as ready for review January 4, 2020 19:25
@shisama shisama requested review from a team as code owners January 4, 2020 19:25
@shisama
chore: stop supporting Node 8
e30348a 
Node.js v8 is scheduled to stop maintenance on December 2019.
Please see https://nodejs.org/en/about/releases/
sidharthachatterjee
sidharthachatterjee previously requested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Lowest supported version should be v10.13.0 since that's the version that Node 10 went into LTS with.

Can you update this PR with that please?

@pvdz
Copy link
Contributor

pvdz commented Jan 6, 2020

Related: gatsbyjs/api.gatsbyjs.org#33

@pvdz
Copy link
Contributor

pvdz commented Jan 6, 2020

I think the yarn.lock file changes also need to be dropped...?

@shisama
Copy link
Contributor Author

shisama commented Jan 6, 2020

@sidharthachatterjee Thank you for your review. I changed lowest version to v10.13.0.

@shisama
Copy link
Contributor Author

shisama commented Jan 6, 2020

@pvdz Thank you. I dropped yarn.lock file change which needs not to be changed.

@sidharthachatterjee sidharthachatterjee self-assigned this Jan 8, 2020
@sidharthachatterjee
Copy link
Contributor

I've added a deprecation warning in #20466

Let's give people a month and then get this in. Marking as blocked for now. Thanks!

@sidharthachatterjee sidharthachatterjee added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Jan 9, 2020
@MichaelDeBoey MichaelDeBoey mentioned this pull request Feb 5, 2020
Closed
@pieh pieh changed the title chore: stop supporting Node 8 chore: more cleanup for Node 8 drop Mar 20, 2020
@pieh
Copy link
Contributor

pieh commented Mar 20, 2020

There are couple of good changes here that we missed in #22400 so I synced it

@pieh pieh removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Mar 20, 2020
pieh
pieh approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We did have separate PR that dropped most of node 8 things, but there are few things we missed there so this PR will still go in

@pieh pieh changed the title chore: more cleanup for Node 8 drop chore: more cleanup after Node 8 drop Mar 20, 2020
@pieh pieh dismissed sidharthachatterjee’s stale review March 20, 2020 14:21

things were updated

@pieh pieh merged commit 8aeb303 into gatsbyjs:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@sidharthachatterjee sidharthachatterjee sidharthachatterjee left review comments

Assignees

@sidharthachatterjee sidharthachatterjee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shisama @pvdz @sidharthachatterjee @pieh