chore(gatsby-cli): Add notice for Node 8 EOL #20466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
added
the
type: maintenance
freiksenet
approved these changes
Jan 8, 2020
freiksenet
suggested changes
Jan 8, 2020
freiksenet
previously approved these changes
Jan 8, 2020
sidharthachatterjee
added
the
bot: merge on green
pieh
reviewed
Jan 8, 2020
KyleAMathews
reviewed
Jan 8, 2020
freiksenet
approved these changes
Jan 9, 2020
delete-merged-branch
bot
deleted the
chore/deprecation-warning-for-node-8
branch
muescha
reviewed
Jan 9, 2020
| report.warn( | ||
| report.stripIndent(` | ||
| Node.js ${process.version} has reached End of Life status on 31 December, 2019. | ||
| Gatsby will only actively support ${NEXT_MIN_NODE_VERSION} or higher and drop support for Node 8 soon. |
There was a problem hiding this comment.
maybe remove here the version number so on the next time we don't need to change the numbers...
Suggested change
| Gatsby will only actively support ${NEXT_MIN_NODE_VERSION} or higher and drop support for Node 8 soon. | |
| Gatsby will only actively support ${NEXT_MIN_NODE_VERSION} or higher and drop support for earlier Node versions soon. |
if ok i can create a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Node 8 has hit EOL, we will stop actively supporting it and raise our minimum supported Node version to the next LTS (10.13) as per support policy.
However, we won't stop support immediately because we currently have roughly 6% of our users using Node < 10.13 (based on data over the past month).
This PR adds a deprecation warning for now and should set the stage for dropping support in a month from now.