fix(gatsby): Fix stack overflow on queries with circular fragments #20936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiksenet
approved these changes
Jan 28, 2020
vladar
added
the
bot: merge on green
pvdz
reviewed
Jan 28, 2020
Comment on lines
+447
to
451
| if (visitedFragmentDefinitions.has(fragmentDefinition)) { | ||
| return | ||
| } | ||
| visitedFragmentDefinitions.add(fragmentDefinition) | ||
| if (fragmentDefinition) { |
There was a problem hiding this comment.
This implies that you may be adding primitives to the visitedFragmentDefinitions set.
If nothing else, I would bet that we could move the 447-450 to be inside the falsy check to prevent falsy values being added to the queue. Or if the value is never falsy, drop the check.
Also, if name is a unique descriptor of these objects then maybe that would be as good a value to use for this purpose.
There was a problem hiding this comment.
Right, fragmentDefinition can be undefined in an edge case. Will move the check inside if (fragmentDefinition) { }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes stack overflow caused by circular fragments. Stack overflow was first introduced here: #19665
Related Issues
Fixes #20826