Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Fix potential issue in fragment cycles detection #20953

Merged
merged 1 commit into from
Jan 28, 2020
Merged

fix(gatsby): Fix potential issue in fragment cycles detection #20953

merged 1 commit into from
Jan 28, 2020

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jan 28, 2020

Description

This is a follow up to the following PR: #20936

It addresses one potential issue mentioned in this review comment: https://github.com/gatsbyjs/gatsby/pull/20936/files#r371815743

@vladar vladar requested a review from pvdz January 28, 2020 16:58
@vladar vladar marked this pull request as ready for review January 28, 2020 16:58
@vladar vladar requested a review from a team as a code owner January 28, 2020 16:58
pvdz
pvdz approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pvdz pvdz merged commit c6f4c62 into master Jan 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the vladar/fragment-cycles-followup branch January 28, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladar @pvdz