Blog 2020-02-05 Accessible Routing #21018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2020 15:42
madalynrose
changed the title
|
LGTM 👍 |
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: LB <barth.laurie@gmail.com>
also add descriptive text for issue #5581
marcysutton
suggested changes
Jan 30, 2020
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
|
|
||
| ### Some Background | ||
|
|
||
| Our first step to addressing focus management (the first recommendation, above) was [switching](/blog/2018-09-27-reach-router/) to [`@reach/router`](https://reach.tech/router). This got us part of the way there out-of-the-box. However, Gatsby’s implementation of `@reach/router` isn’t idiomatic in that Gatsby puts everything on a single, catch-all route. This means that every page is technically on the same route and route changes weren’t getting picked up by `@reach/router`. Our improvements in [2.13.2](https://github.com/gatsbyjs/gatsby/pull/13197) made sure that every time a route changed, we reset focus on a wrapping `div`. These changes also ensure that our single, catch-all route is dynamic so we can register changes and take advantage of `@reach/router’s` strengths. |
There was a problem hiding this comment.
We should add up front that this didn't work in some assistive technologies–that was why work on the router needed to continue (NVDA and VoiceOver weren't actually working even with that fix, which meant the related GitHub issue couldn't be closed).
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
marcysutton
suggested changes
Feb 1, 2020
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-05-accessible-client-side-routing-improvements/index.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
Ekwuno
previously approved these changes
Feb 5, 2020
…-05-accessible-routing
hashimwarren
added
the
bot: merge on green
marcysutton
previously approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Great work, @madalynrose! Looking forward to seeing this out in the world!!
…-05-accessible-routing
sidharthachatterjee
dismissed stale reviews from marcysutton and Ekwuno
via
16b5a76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blog post announcing changes that went out in #19290 and #20914 (I'm lumping them together because I want people to use the version that came after the latter was released)
Related Issues
Related to #5581