Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog 2020-02-05 Accessible Routing #21018
Blog 2020-02-05 Accessible Routing #21018
Changes from 5 commits
93161c0
733b0bb
7e5bc37
c86e9ab
b5bd870
7987e54
9d5d589
fef7aaa
5d8d6ff
82110a4
448fa9c
97e083d
52a7ddd
16b5a76
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add up front that this didn't work in some assistive technologies–that was why work on the router needed to continue (NVDA and VoiceOver weren't actually working even with that fix, which meant the related GitHub issue couldn't be closed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to disambiguate that skip link from the research recommendation though, because we aren't sending focus to it automatically. This was the same trap that Marcus Herrmann fell into for Vue recommendations, in that he read it as "the next item in the tab order" : but it misses the part about supporting low vision and limited mobility users with visible focus on a small control on route change: https://twitter.com/_marcusherrmann/status/1222898316129603584
The Reach Skip Nav is a component that could take focus on route change, but we aren't currently using it that way.