(blog) Bulding multilingual sites with Gatsby #21517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AishaBlake
suggested changes
Feb 20, 2020
There was a problem hiding this comment.
Hello! Thanks so much for writing this. It's, of course, of particular interest given the work being done to internationalize the Gatsby docs. I've got a handful of suggested changes. Anything without a comment is a pure suggestion and shouldn't block merging.
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
…by/index.md Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
|
Thank you @AishaBlake, all the suggestions should now be resolved. |
|
@AishaBlake @hashimwarren is there anything else I should adjust before merging please? |
hashimwarren
approved these changes
Mar 2, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blog post topic pre-approved by Hashim Warren