Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): Building multilingual sites with Gatsby #22020

Merged

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Mar 6, 2020

Description

NOTE: i split to to separate PR - see last comment

adjustments:

  • fix relative path on internal links
  • fix codeblock languages
  • add code fences at some constants
  • changed all intends to 2 tabs
  • add code line from previous example, to show where variable person comes from

Related Issues

@muescha muescha requested a review from a team as a code owner March 6, 2020 19:38
@muescha muescha changed the title fix(blog): Bulding multilingual sites with Gatsby fix(blog): Building multilingual sites with Gatsby Mar 17, 2020
@muescha muescha force-pushed the muescha/fix/blog-how-to-multilingual branch from 8c15019 to 3674408 Compare March 17, 2020 17:36
@muescha
Copy link
Contributor Author

muescha commented Apr 8, 2020

i will split this into separate PR for easy check.

adjustments:

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, see my comment below.

@laurieontech
Copy link
Contributor

Also, since this was left open and the others are duplicates of smaller changes I'm going to close those.
In the future, if you break things up please close the umbrella issue.

@muescha
Copy link
Contributor Author

muescha commented Apr 8, 2020

in #22205 (comment) you said i should split it into smaller packages to make PR easy to check

open tightly-scoped PRs for each chunk of work, such as a section of the tutorial, to make it easier for us to review and test

and i agree it is more easy to check the small chunks

but why you closed the smaller ones? i am confused

@laurieontech
Copy link
Contributor

You're correct. However, this PR was first and stayed open. Therefore I reviewed this prior to looking at the smaller ones. So I closed the ones that were no longer relevant.

Going forward you should close the larger PR when you make the smaller ones so that there aren't duplicates.

@muescha
Copy link
Contributor Author

muescha commented Apr 8, 2020

ok :)

👍

@muescha muescha changed the title (WIP) fix(blog): Building multilingual sites with Gatsby fix(blog): Building multilingual sites with Gatsby Apr 8, 2020
@laurieontech
Copy link
Contributor

Looks good!

@laurieontech laurieontech merged commit 59fad43 into gatsbyjs:master Apr 8, 2020
@muescha muescha deleted the muescha/fix/blog-how-to-multilingual branch April 8, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants