-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blog): Building multilingual sites with Gatsby #22020
fix(blog): Building multilingual sites with Gatsby #22020
Conversation
8c15019
to
3674408
Compare
i will split this into separate PR for easy check. adjustments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, see my comment below.
docs/blog/2020-02-19-how-to-build-multilingual-sites-with-gatsby/index.md
Outdated
Show resolved
Hide resolved
Also, since this was left open and the others are duplicates of smaller changes I'm going to close those. |
in #22205 (comment) you said i should split it into smaller packages to make PR easy to check
and i agree it is more easy to check the small chunks but why you closed the smaller ones? i am confused |
You're correct. However, this PR was first and stayed open. Therefore I reviewed this prior to looking at the smaller ones. So I closed the ones that were no longer relevant. Going forward you should close the larger PR when you make the smaller ones so that there aren't duplicates. |
ok :) 👍 |
Looks good! |
Description
NOTE: i split to to separate PR - see last comment
adjustments:
person
comes fromRelated Issues
(blog) Bulding multilingual sites with Gatsby