Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(coffee): reword test to fix typo #23477

Merged
merged 2 commits into from
May 6, 2020

Conversation

Slashgear
Copy link
Contributor

@Slashgear Slashgear commented Apr 25, 2020

Description

  • fix typo in test title
  • decouple test implementation from coffee compiler
  • remove usage of snapshot

Documentation

No need to update doc here I think

Related Issues

@Slashgear Slashgear requested a review from a team as a code owner April 25, 2020 13:13
- fix typo
- decouple test implementation from coffee compiler
@Slashgear Slashgear changed the title test(coffee): enhance test by removing snapshot test(coffee): reword test to fix typo May 6, 2020
@Slashgear Slashgear requested a review from pieh May 6, 2020 08:54
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Always good to limit snapshots to things that make sense and not overuse it (as it get's pretty unwieldy and hard to follow if there are too much snapshot tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants