test(gatsby-transformer-asciidoc): init some tests #23611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
approved these changes
May 5, 2020
There was a problem hiding this comment.
Let's get this in. Thanks for doing work on adding tests for those plugins that don't have any!
I'll merge the PR, but for potential follow up - I have some question
mock asciidoctor usage because it was quite complicate to make it work in the jest context
That's unfortunate, could you expand on what kind of problems you saw?
|
Will check this that PR when I'm back in front of computer. Reviews on mobile are less than ideal ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
asciidoctransformerasciidoctorusage because it was quite complicate to make it work in the jest contextDocumentation
Related Issues