Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Update resolve-module-exports to TS #24519

Merged
merged 1 commit into from
May 27, 2020
Merged

chore(gatsby): Update resolve-module-exports to TS #24519

merged 1 commit into from
May 27, 2020

Conversation

Eyas
Copy link
Contributor

@Eyas Eyas commented May 27, 2020

Description

This PR migrates packages/gatsby/src/bootstrap/resolve-module-exports to TypeScript.

Related Issues

Unblocks #22504. Part of #21995.

@Eyas Eyas requested a review from a team as a code owner May 27, 2020 00:06
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 27, 2020
@Eyas Eyas mentioned this pull request May 27, 2020
Merged
@blainekasten blainekasten mentioned this pull request May 27, 2020
Closed
@vladar vladar added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 27, 2020
blainekasten
blainekasten approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: needs core review Currently awaiting review from Core team member labels May 27, 2020
@gatsbybot gatsbybot merged commit 156e949 into gatsbyjs:master May 27, 2020
johno pushed a commit to johno/gatsby that referenced this pull request May 28, 2020
@Eyas @johno
chore(gatsby): Update resolve-module-exports to TS (gatsbyjs#24519)
fe6542e
axe312ger pushed a commit that referenced this pull request Jun 23, 2020
@Eyas @axe312ger
chore(gatsby): Update resolve-module-exports to TS (#24519)
6f2bf93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eyas @blainekasten @vladar @gatsbybot