Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and linter dictionary errors #26371

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Fix typos and linter dictionary errors #26371

merged 4 commits into from
Aug 11, 2020

Conversation

laurieontech
Copy link
Contributor

Linter was failing on dictionary words. This fixes a handful of typos and adds the rest to the dictionary.

@laurieontech laurieontech requested a review from a team as a code owner August 11, 2020 18:31
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 11, 2020
@laurieontech laurieontech added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 11, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 11, 2020 •
edited
Loading

Gatsby Cloud Build Report

client-only-paths

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 10s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 🔶 85
Best Practices 💚 100
SEO 🔶 70

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 11, 2020 •
edited
Loading

Gatsby Cloud Build Report

using-styled-components

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 12s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 90
Best Practices 💚 100
SEO 💚 90

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 11, 2020 •
edited
Loading

Gatsby Cloud Build Report

using-reach-skip-nav

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 13s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 82

🔗 View full report

AishaBlake
AishaBlake reviewed Aug 11, 2020
View reviewed changes
dictionary.txt Outdated Show resolved Hide resolved
@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Aug 11, 2020 •
edited
Loading

Gatsby Cloud Build Report

gatsby-master

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 93
Accessibility 🔶 87
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

AishaBlake
AishaBlake approved these changes Aug 11, 2020
View reviewed changes
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for the quick fixes, Laurie!

@laurieontech laurieontech merged commit fd2194f into master Aug 11, 2020
This was referenced Aug 12, 2020
Merged
Merged
@LekoArts LekoArts deleted the docs-fix-linting branch November 9, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AishaBlake AishaBlake AishaBlake approved these changes

Assignees
No one assigned
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurieontech @AishaBlake