Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update react-dev-utils, react-error-overlay #26697

Closed
wants to merge 2 commits into from

Conversation

herecydev
Copy link
Contributor

@herecydev herecydev commented Aug 29, 2020

⚠ No changelog about breaking changes

Testing

Test 1 (wrong import)

import { Link } from "gatsby" => import { Links } from "gatsby"

Before

image

image

After

image

image

Test 2 (missing react import)

Before

image

image

After

import React from "react" => (removed)

image

image

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 29, 2020
@herecydev herecydev changed the title Update packages chore: update react-dev-utils, react-error-overlay Aug 29, 2020
@hoobdeebla
Copy link
Contributor

I looked through the commit logs for what Gatsby uses and found these results:

methods used current version published updated version published changes between current and updated versions
react-dev-utils/formatWebpackMessages 2018-10-14 2020-03-21 update error messages, ESLint/typo fixes - none breaking
react-dev-utils/launchEditor 2018-10-14 2020-03-21 additional editors added, Windows fixes - none breaking
react-error-overlay 2017-10-30 2020-03-21 add dark mode, update error messages, ESLint/typo fixes - none breaking

the "breaking" changes I found were all updating devDependencies for testing and making production builds - nothing that impacts the user directly

@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 31, 2020
@herecydev
Copy link
Contributor Author

Looks like the formatWebpackMessages is called but effectively the results are discarded. I'm not sure what the background is on that one but there's overlap with reportWebpackWarnings and structureWebpackErrors. These leads to some inconsitencies that would be good to address. For example:

image

Displays a warning without line numbers

image

And the error overlay isn't helpful:

image

If you compare that to the "structured webpack errors" in my first few screenshots, they are much clearer and easier to work with.

@herecydev herecydev marked this pull request as ready for review September 1, 2020 17:53
@LekoArts
Copy link
Contributor

LekoArts commented Mar 1, 2021

Thanks for the PR!

With #29540, #29588 & #29864 merged updates to the packages are not needed anymore :)

@LekoArts LekoArts closed this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants