Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove react-hot-loader #29540

Merged
merged 8 commits into from
Feb 18, 2021
Merged

feat: remove react-hot-loader #29540

merged 8 commits into from
Feb 18, 2021

Conversation

wardpeet
Copy link
Contributor

Description

Removes react-hot-loader and sets fast-refresh as the only default.

Documentation

Not that I know of

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 17, 2021
@wardpeet wardpeet added status: needs core review Currently awaiting review from Core team member type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 17, 2021
@wardpeet wardpeet force-pushed the feat/remove-react-hot-loader branch from 1dd4e4e to 6352061 Compare February 18, 2021 07:17
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to bump up Gatsby's react devDependencies to a minimum version that supports fast refresh

@wardpeet
Copy link
Contributor Author

You'll want to bump up Gatsby's react devDependencies to a minimum version that supports fast refresh

That's for another PR

@sidharthachatterjee
Copy link
Contributor

@wardpeet Alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs core review Currently awaiting review from Core team member type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants