-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove react-hot-loader #29540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 17, 2021
wardpeet
added
status: needs core review
Currently awaiting review from Core team member
type: maintenance
An issue or pull request describing a change that isn't a bug, feature or documentation change
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Feb 17, 2021
wardpeet
force-pushed
the
feat/remove-react-hot-loader
branch
from
February 18, 2021 07:17
1dd4e4e
to
6352061
Compare
sidharthachatterjee
suggested changes
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to bump up Gatsby's react devDependencies to a minimum version that supports fast refresh
That's for another PR |
@wardpeet Alright |
sidharthachatterjee
approved these changes
Feb 18, 2021
This was referenced Mar 1, 2021
This was referenced Mar 12, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: needs core review
Currently awaiting review from Core team member
type: maintenance
An issue or pull request describing a change that isn't a bug, feature or documentation change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes react-hot-loader and sets fast-refresh as the only default.
Documentation
Not that I know of
Related Issues