fix:gatsby-remark-autolink-headers option to disable "position: relat… #26992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: remark/mdx
|
Thanks for the PR! A snapshot test is failing, can you please update that, too? Please let us know if you need further help :) |
|
Just a small correction. "This fix applies relative positioning only when the icon is |
|
@LekoArts @don-esteban I have made another PR which passes all the tests. => #27022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26961 (comment)
Description
gatsby-remark-autolink-headershasstyle:"position:relative"which doesn't always work as intended. The inline style is needed for the icon option to function as it positions said icon with style of absolute or inline-block.This fix applies relative positioning only when the icon is present.Documentation
Related Issues
Fixes #26961