Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-remark-autolink-headers): option to disable "position: relative" when icon is not present #27022

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

parulc7
Copy link
Contributor

@parulc7 parulc7 commented Sep 24, 2020

Description

gatsby-remark-autolink-headers always use relative positioning. However, this doesn't always work fine. This Pull Request aims to fix this issue and provide relative positioning only when the icon is present.

Documentation

Related Issues

Fixes #26961

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 24, 2020
@parulc7
Copy link
Contributor Author

parulc7 commented Sep 25, 2020

@LekoArts

@LekoArts LekoArts added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 25, 2020
@parulc7
Copy link
Contributor Author

parulc7 commented Sep 25, 2020

@LekoArts How to get someone to review my PR?

@LekoArts
Copy link
Contributor

@parulc7 Please refrain from tagging people, the PR will be reviewed during working days (so not on the weekend) and they are on our radar.

@LekoArts LekoArts changed the title fix:gatsby-remark-autolink-headers option to disable "position: relative" when icon is not present fix(gatsby-remark-autolink-headers): option to disable "position: relative" when icon is not present Sep 28, 2020
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit 8807fea into gatsbyjs:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-remark-autolink-headers: option to disable style="position: relative"
2 participants