-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-remark-autolink-headers): option to disable "position: relative" when icon is not present #27022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 24, 2020
LekoArts
added
topic: remark/mdx
Related to Markdown, remark & MDX ecosystem
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Sep 25, 2020
@LekoArts How to get someone to review my PR? |
@parulc7 Please refrain from tagging people, the PR will be reviewed during working days (so not on the weekend) and they are on our radar. |
LekoArts
changed the title
fix:gatsby-remark-autolink-headers option to disable "position: relative" when icon is not present
fix(gatsby-remark-autolink-headers): option to disable "position: relative" when icon is not present
Sep 28, 2020
LekoArts
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This was referenced Jan 13, 2022
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby-remark-autolink-headers always use relative positioning. However, this doesn't always work fine. This Pull Request aims to fix this issue and provide relative positioning only when the icon is present.
Documentation
Related Issues
Fixes #26961