feat(gatsby): Respect VERBOSE env var #29708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sidharthachatterjee
removed
the
status: triage needed
ascorbic
reviewed
Feb 23, 2021
sidharthachatterjee
changed the title
pieh
previously approved these changes
Feb 23, 2021
sidharthachatterjee
added
the
bot: merge on green
pieh
approved these changes
Feb 23, 2021
ascorbic
approved these changes
Feb 23, 2021
|
A bit late jumping in here but why don't we solve this more generally and let people set the logging level for when we create the CLI? gatsby/packages/gatsby-cli/src/create-cli.ts Lines 117 to 118 in 796be7e |
|
e.g. |
ascorbic
pushed a commit
that referenced
this pull request
Feb 23, 2021
* Respect GC_VERBOSE env var * Switch to VERBOSE * Support VERBOSE in build as well Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit 97d6d3e)
|
@KyleAMathews We could do that. But I just added this for feature parity for Incremental Builds and Preview. The latter didn't support verbose logging at all. |
|
👍 not a big deal either way so parity makes sense
--
Kyle Mathews
Blog: *http://bricolage.io <http://bricolage.io>*
Twitter: http://twitter.com/kylemathews
…On Wed, Feb 24, 2021 at 8:30 AM Sidhartha Chatterjee < ***@***.***> wrote:
@KyleAMathews <https://github.com/KyleAMathews> We could do that. But I
just added this for feature parity for Incremental Builds and Preview. The
latter didn't support verbose logging at all.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#29708 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGDWMDL24AUF7G6KAHQXLNTTAUSRRANCNFSM4YCUEUNQ>
.
|
ascorbic
added a commit
that referenced
this pull request
Feb 24, 2021
* feat(gatsby): Respect VERBOSE env var (#29708) * Respect GC_VERBOSE env var * Switch to VERBOSE * Support VERBOSE in build as well Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit 97d6d3e) * Add back chalk Co-authored-by: Sidhartha Chatterjee <me@sidharthachatterjee.com> Co-authored-by: Matt Kane <matt@gatsbyjs.com>
|
Published in |
This was referenced Oct 31, 2022
This was referenced Dec 6, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gatsby develop
Incremental Builds supports this so we want feature parity for Preview
This depends on #29707