Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Respect VERBOSE env var #29708

Merged
merged 4 commits into from
Feb 23, 2021
Merged

feat(gatsby): Respect VERBOSE env var #29708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
464f7e2
Respect GC_VERBOSE env var
sidharthachatterjee Feb 23, 2021
094b633
Switch to VERBOSE
sidharthachatterjee Feb 23, 2021
f00cd97
Merge remote-tracking branch 'upstream/master' into feat/enable-verbo…
Feb 23, 2021
7701c9d
Support VERBOSE in build as well
sidharthachatterjee Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/gatsby/src/commands/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ import {
markWebpackStatusAsPending,
markWebpackStatusAsDone,
} from "../utils/webpack-status"
import { updateSiteMetadata } from "gatsby-core-utils"
import { updateSiteMetadata, isTruthy } from "gatsby-core-utils"

module.exports = async function build(program: IBuildArgs): Promise<void> {
report.setVerbose(program.verbose)
report.setVerbose(isTruthy(process.env.VERBOSE) || program.verbose)

if (program.profile) {
report.warn(
Expand Down
4 changes: 2 additions & 2 deletions packages/gatsby/src/commands/develop-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { syncStaticDir } from "../utils/get-static-dir"
import reporter from "gatsby-cli/lib/reporter"
import chalk from "chalk"
import telemetry from "gatsby-telemetry"
import { isTruthy } from "gatsby-core-utils"
import express from "express"
import inspector from "inspector"
import { initTracer } from "../utils/tracer"
Expand Down Expand Up @@ -80,7 +80,7 @@ const openDebuggerPort = (debugInfo: IDebugInfo): void => {
}

module.exports = async (program: IDevelopArgs): Promise<void> => {
reporter.setVerbose(program.verbose)
reporter.setVerbose(isTruthy(process.env.VERBOSE) || program.verbose)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that this isn't complete - we should set program.vebose to true if env var is truthy because of things like

gatsby/packages/gatsby/src/commands/develop-process.ts

Lines 135 to 137 in a8f7101

if (program.verbose) {
logTransitions(service)
}
which check if (program.verbose) before doing some potentially expensive things


if (program.debugInfo) {
openDebuggerPort(program.debugInfo)
Expand Down