Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden : ign-sensors7 #9

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Bumps in garden : ign-sensors7 #9

merged 2 commits into from
Apr 13, 2022

Conversation

methylDragon
Copy link
Contributor

methylDragon and others added 2 commits April 12, 2022 18:38
@methylDragon
Bumps in garden : ign-sensors7
4fd6b41
@chapulina
Remove direct dependency on ign-plugin.
254f305 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

I just removed the ign-plugin dependency on 254f305, it isn't needed since

And we don't need to explicitly declare the indirect dependency here, because ign-rendering will bring it by itself. Which is a different situation from

CC @scpeters

@chapulina chapulina merged commit 18bba54 into main Apr 13, 2022
@chapulina chapulina deleted the ci_matching_branch/bump_garden_ign-sensors7 branch April 13, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina