Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign-sensors[6,7] don't depend on ign-plugin #82

Closed
wants to merge 1 commit into from
Closed

ign-sensors[6,7] don't depend on ign-plugin #82

wants to merge 1 commit into from

Conversation

chapulina
Copy link
Contributor

The dependency was removed in this PR:

But we forgot to update gazebodistro.

@chapulina
ign-sensors[6,7] don't depend on ign-plugin
3baac44 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
methylDragon
methylDragon approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scpeters
scpeters requested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ign-plugin is not a direct dependency, but it is a recursive dependency via ign-rendering

@chapulina
Copy link
Contributor Author

Ahh nice catch, @scpeters . Closing.

@chapulina chapulina closed this Apr 13, 2022
@chapulina chapulina deleted the chapulina/sensors_plugin branch April 13, 2022 23:41
@chapulina chapulina mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters requested changes

@methylDragon methylDragon methylDragon approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @scpeters @methylDragon