Source the libraries before executing the tests #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/fix/source_ws
branch
from
6f8649e
to
ed06795
Compare
chapulina
reviewed
Sep 17, 2020
| @@ -154,6 +154,7 @@ fi | |||
| echo ::group::make test | |||
| export CTEST_OUTPUT_ON_FAILURE=1 | |||
| cd "$GITHUB_WORKSPACE"/build | |||
| . colcon_command_prefix_test.sh | |||
There was a problem hiding this comment.
The only part of the code that uses colcon is when compiling dependencies from source, see line 93 above. And that's sourcing the workspace. I'm not sure what this line is supposed to be doing.
The PR you mentioned, gazebosim/gz-sensors#38, isn't installing any dependencies from source, so that build shouldn't need colcon at all.
Maybe what you need is a make install on after_make.sh like this?
There was a problem hiding this comment.
Line 93 only source the dependencies if you include some dependencies from source.
This file is only going to load the package.sh of the dependencies included in the CMakeLists.txt. An example:
# generated from colcon_core/shell/template/command_prefix.sh.em
. "/home/ahcorde/ignition_dome/install/share/ignition-cmake2/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-math6/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-plugin1/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-rendering4/package.sh"This other approach may require:
- include
-DCMAKE_INSTALL_PREFIXto the cmake call - source this directoryif it's not default one
- and
make install
or make install- setup manually
LD_LIBRARY_PATHbecause make install will install this new library in/usr/localnot in/usr/. See here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having some problem with the ignition-sensors tests. When we are executing the tests some libraries are not availables. This is because the ignition libraries are not sourced.
This should be ported to master too.
@chapulina @j-rivero
Signed-off-by: ahcorde ahcorde@gmail.com