Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source the libraries before executing the tests #24

Closed
wants to merge 1 commit into from
Closed

Source the libraries before executing the tests #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ fi
echo ::group::make test
export CTEST_OUTPUT_ON_FAILURE=1
cd "$GITHUB_WORKSPACE"/build
. colcon_command_prefix_test.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only part of the code that uses colcon is when compiling dependencies from source, see line 93 above. And that's sourcing the workspace. I'm not sure what this line is supposed to be doing.

The PR you mentioned, gazebosim/gz-sensors#38, isn't installing any dependencies from source, so that build shouldn't need colcon at all.

Maybe what you need is a make install on after_make.sh like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 93 only source the dependencies if you include some dependencies from source.

This file is only going to load the package.sh of the dependencies included in the CMakeLists.txt. An example:

# generated from colcon_core/shell/template/command_prefix.sh.em
. "/home/ahcorde/ignition_dome/install/share/ignition-cmake2/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-math6/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-plugin1/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-rendering4/package.sh"

This other approach may require:

  • include -DCMAKE_INSTALL_PREFIX to the cmake call
  • source this directoryif it's not default one
  • and make install
    or
  • make install
  • setup manually LD_LIBRARY_PATH because make install will install this new library in /usr/local not in /usr/ . See here

make test
echo ::endgroup::

Expand Down