Enable nighty mode when using nightly on VERSION instead of UPLOAD_TO_REPO #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_REPO Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
azeey
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly mode in debbuild base is enabled when "nightly" value is detected in
UPLOAD_TO_REPO. This is preventing theUPLOAD_TO_REPOto set the valuenonefor testing and test a nightly with it. Seems more logical to use theVERSIONfield since there is no case where you want to use thenightlyvalue in that field for a different reason that to build a nightly.The nightly scheduler pass the
nightlyvalue in the second arg (VERSION) so the nightly builds should not be affected.Tested