Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport GZ_DESIGNATION tick-tock #284

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Backport GZ_DESIGNATION tick-tock #284

merged 1 commit into from
Jul 22, 2022

Conversation

scpeters
Copy link
Member

🎉 New feature

Partial backport of #277, alternative to #282.

Summary

Backport the tick-tock of IGN_DESIGNATION / GZ_DESIGNATION.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Backport GZ_DESIGNATION tick-tock
6f99a9b 
Partial backport of #277.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 20, 2022
@scpeters scpeters mentioned this pull request Jul 20, 2022
Closed
9 tasks
chapulina
chapulina approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the diff between this PR and #282

I'm ok with these changes.

@chapulina chapulina requested a review from nkoenig July 20, 2022 17:36
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 20, 2022
@scpeters scpeters merged commit 8c91364 into ign-cmake2 Jul 22, 2022
@scpeters scpeters deleted the scpeters/backport_gz_designation branch July 22, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig nkoenig approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @nkoenig @chapulina