Gz designation #282
Closed
Gz designation #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 20, 2022 05:50
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
chapulina
suggested changes
Jul 20, 2022
This was referenced Jul 20, 2022
chapulina
suggested changes
Jul 20, 2022
| # | ||
| # NO_IGNITION_PREFIX: Optional. Don't use ignition as prefix in | ||
| # cmake project name. | ||
| # REPLACE_IGNITION_INCLUDE_PATH: Optional. Specify include folder | ||
| # names to replace the default value of | ||
| # ignition/${IGN_DESIGNATION} | ||
| # gazebo/${GZ_DESIGNATION} |
There was a problem hiding this comment.
We shouldn't change the include paths in stable releases because that's not backwards compatible
Suggested change
| # gazebo/${GZ_DESIGNATION} | |
| # ignition/${GZ_DESIGNATION} |
| @@ -2,8 +2,8 @@ prefix=${pcfiledir}/@PC_CONFIG_RELATIVE_PATH_TO_PREFIX@ | |||
| libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@ | |||
| includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@/@IGN_INCLUDE_INSTALL_DIR_POSTFIX@ | |||
|
|
|||
| Name: Ignition @IGN_DESIGNATION@ @component_name@ | |||
| Description: A set of @IGN_DESIGNATION@ @component_name@ classes for robot applications | |||
| Name: Gazebo @GZ_DESIGNATION@ @component_name@ | |||
There was a problem hiding this comment.
This will be weird for ign-gazebo, because the designation will still be "Gazebo", so this becomes Gazebo Gazebo
| @@ -2,8 +2,8 @@ prefix=${pcfiledir}/@PC_CONFIG_RELATIVE_PATH_TO_PREFIX@ | |||
| libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@ | |||
| includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@/@IGN_INCLUDE_INSTALL_DIR_POSTFIX@ | |||
|
|
|||
| Name: Ignition @IGN_DESIGNATION@ | |||
| Description: A set of @IGN_DESIGNATION@ classes for robot applications | |||
| Name: Gazebo @GZ_DESIGNATION@ | |||
There was a problem hiding this comment.
Same thing here about "Gazebo Gazebo"
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Changes
IGN_DESIGNATIONtoGZ_DESIGNATION.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.