Deprecate GzPython.cmake #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to call find_package(Python3) directly so the user has better control over which COMPONENTS are requested. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
29 tasks
Update GzBuildTests.cmake and GzCodeCheck.cmake to stop using GzPython. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
caguero
approved these changes
May 27, 2024
scpeters
commented
May 28, 2024
| set(Python3_EXECUTABLE ${PYTHON_EXECUTABLE}) | ||
| endif() | ||
| endif() | ||
| find_package(Python3 ${GZ_PYTHON_VERSION} QUIET) | ||
|
|
||
| # Tick-tock PYTHON_EXECUTABLE until Python3_EXECUTABLE is released | ||
| # TODO(jrivero) gz-cmake4: start the deprecation cycle of PYTHON_EXECUTABLE |
There was a problem hiding this comment.
I just noticed some uses of PYTHON_EXECUTABLE; I'll clean those up before merging this
There was a problem hiding this comment.
primarily here: https://github.com/gazebosim/gz-sim/blob/main/python/CMakeLists.txt#L12
that's old cmake code that will be removed as part of #350, so actually it shouldn't be a problem
There was a problem hiding this comment.
it will be removed in gazebosim/gz-sim#2420
There was a problem hiding this comment.
that has been merged, so I'll merge this as well
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #350
Summary
Using
GzPython.cmaketo find python is not ideal since it's best to find python once with the components that you need. Now thatfind_package(Python3)works well, it's best to just use that.All Gazebo packages in Ionic have stopped using
GzPython, so this should be safe to merge.Test it
Compile Gazebo Ionic from source against this branch and ensure there are no cmake warnings from using GzPython and that python bindings are properly built for each package.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.