-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 24.04 CI, require cmake 3.22.1 #2420
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
there are some cmake warnings that should be resolved |
actually these cmake warnings are preexisting on |
|
CI is relatively happy now, just a flaky test failure on windows
|
🎉 New feature
Part of gazebosim/gz-cmake#350.
Summary
This adds a GitHub workflow using Noble and increases our minimum required cmake version to 3.22.1 since we are already requiring that in gz-cmake4. It also removes some old code to support older versions of cmake.
Test it
Look at the 24.04 CI results.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.