Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 24.04 CI, require cmake 3.22.1 #2420

Merged
merged 6 commits into from
Jun 1, 2024
Merged

Enable 24.04 CI, require cmake 3.22.1 #2420

merged 6 commits into from
Jun 1, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebosim/gz-cmake#350.

Summary

This adds a GitHub workflow using Noble and increases our minimum required cmake version to 3.22.1 since we are already requiring that in gz-cmake4. It also removes some old code to support older versions of cmake.

Test it

Look at the 24.04 CI results.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Part of gazebosim/gz-cmake#350.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

there are some cmake warnings that should be resolved

@scpeters
Copy link
Member Author

there are some cmake warnings that should be resolved

actually these cmake warnings are preexisting on main, but I'll see if I can fix them here anyway

@scpeters
Copy link
Member Author

there are some cmake warnings that should be resolved

actually these cmake warnings are preexisting on main, but I'll see if I can fix them here anyway

fix from #2397 is being merged forward in #2422

@scpeters scpeters merged commit 6f46876 into main Jun 1, 2024
7 of 8 checks passed
@scpeters scpeters deleted the scpeters/noble_ci branch June 1, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants