Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ 3.8.0 #137

Merged
merged 1 commit into from
Dec 15, 2020
Merged

⬆️ 3.8.0 #137

merged 1 commit into from
Dec 15, 2020

Conversation

mjcarroll
Copy link
Contributor

Signed-off-by: Michael Carroll michael@openrobotics.org

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #137 (25fdad3) into ign-common3 (f5eaee6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #137   +/-   ##
============================================
  Coverage        75.38%   75.38%           
============================================
  Files               69       69           
  Lines             9493     9493           
============================================
  Hits              7156     7156           
  Misses            2337     2337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5eaee6...25fdad3. Read the comment docs.

@chapulina
Copy link
Contributor

Can we wait for #131 and #132 to get in?

@mjcarroll
Copy link
Contributor Author

This was mainly to get @gonzodepedro unblocked on gazebosim/gz-sim#474.

I spoke with @iche033 and he said he wasn't in a huge hurry to get those two PRs in, but we can wait if need be.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mainly to get @gonzodepedro unblocked on gazebosim/gz-sim#474.

Oh sure, I wouldn't block the release on the lightmaps if there's something urgent pending on it. It looks like gazebosim/gz-sim#474 still needs to be approved though...

@mjcarroll mjcarroll changed the title Prepare for 3.8.0 ⬆️ 3.8.0 Dec 15, 2020
@mjcarroll mjcarroll merged commit f26df3c into ign-common3 Dec 15, 2020
@mjcarroll mjcarroll deleted the release/3.8.0 branch December 15, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants