Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BVH and STL loader tests #466

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 26, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Closes #

Summary

Added BVH and STL loader tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 26, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #466 (0342e2e) into ign-common3 (753566f) will increase coverage by 2.73%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-common3     #466      +/-   ##
===============================================
+ Coverage        78.91%   81.65%   +2.73%     
===============================================
  Files               72       72              
  Lines             9244     9244              
===============================================
+ Hits              7295     7548     +253     
+ Misses            1949     1696     -253     
Impacted Files Coverage Δ
src/SystemPaths.cc 88.51% <0.00%> (+0.42%) ⬆️
graphics/src/Skeleton.cc 43.36% <0.00%> (+0.88%) ⬆️
graphics/src/NodeAnimation.cc 53.60% <0.00%> (+5.15%) ⬆️
graphics/src/SkeletonAnimation.cc 46.25% <0.00%> (+6.25%) ⬆️
graphics/src/STLLoader.cc 76.15% <0.00%> (+72.84%) ⬆️
graphics/src/BVHLoader.cc 87.24% <0.00%> (+87.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde changed the base branch from gz-common5 to ign-common3 October 26, 2022 10:53
@mjcarroll
Copy link
Contributor

New segfault on Windows.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 26, 2022

New segfault on Windows.

#468

Signed-off-by: ahcorde <ahcorde@gmail.com>
@mjcarroll
Copy link
Contributor

Hmm, segfault on focal as well.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 26, 2022

Hmm, segfault on focal as well.

Moved MeshCSG test to this other PR #469

@mjcarroll mjcarroll merged commit 1157051 into ign-common3 Oct 26, 2022
@mjcarroll mjcarroll deleted the ahcorde/3/coverage_loaders branch October 26, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants