Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MeshCSG test #469

Closed
wants to merge 3 commits into from
Closed

Added MeshCSG test #469

wants to merge 3 commits into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 26, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Added MeshCSG test. Created as a draft because is failing randomly. I need to debug the code.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Added MeshCSG test
8ebdb74 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 26, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 26, 2022
@ahcorde ahcorde mentioned this pull request Oct 26, 2022
Merged
9 tasks
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 31, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey
Copy link
Contributor

azeey commented Aug 1, 2024

@ahcorde do we want to keep this in beta. Alternatively, since it hasn't been active in a while, maybe we can close it?

@azeey
Copy link
Contributor

azeey commented Aug 6, 2024

MeshCSG is being removed in #617, so I'll go ahead and close this.

@azeey azeey closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoag marcoag Awaiting requested review from marcoag marcoag will be requested when the pull request is marked ready for review marcoag is a code owner

Assignees

@ahcorde ahcorde

Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @azeey @mjcarroll