Use world name in default topics #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui2 #104 +/- ##
============================================
+ Coverage 60.18% 60.43% +0.25%
============================================
Files 16 16
Lines 2082 2108 +26
============================================
+ Hits 1253 1274 +21
- Misses 829 834 +5
Continue to review full report at Codecov.
|
caguero
approved these changes
Aug 11, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with gazebosim/gz-sim#278.
This adds support for retrieving world names from the main window and makes use of that on the
WorldControlandWorldStatsplugins.This doesn't change the default behaviour of those plugins. Their
<topic>s and<service>s will still be respected. But now we default to/world/<world name>/somethingtopics if nothing is set.I was afraid of bringing
ign-gazebo's concept of worlds toign-guiwhen it doesn't need it. But considering that this concept is already built into the 2 plugins in question and is completely optional to all other plugins, I thought this was something reasonable to bring here.